Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles: Level global styles specificity at 0-1-0 #6633

Conversation

aaronrobertshaw
Copy link

@aaronrobertshaw aaronrobertshaw commented May 26, 2024

To make overriding core styles easier and enable the extension of block style variations as a means for section styling, it is necessary to limit the specificity of global styles CSS output.

Further context can be found in: WordPress/gutenberg#57537

Syncs changes from:

Trac ticket: https://core.trac.wordpress.org/ticket/61165


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented May 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aaronrobertshaw, isabel_brison, mukesh27, andrewserong.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@aaronrobertshaw
Copy link
Author

@tellthemachines and @andrewserong, if you get the chance, it would be great if you could confirm this backport covers all it should from previous zero-specificity work and the closed PR: #6522

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM and it's testing correctly on my local. Just need to add @since 6.6.0 (for functions) and @ticket [ticket number] (for tests) and should be good to go!

src/wp-includes/class-wp-theme-json.php Outdated Show resolved Hide resolved
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, this is all testing nicely for me, too!

Just need to add @SInCE 6.6.0 (for functions) and @ticket [ticket number] (for tests) and should be good to go!

+1 🚀

@aaronrobertshaw aaronrobertshaw force-pushed the update/global-styles-specificity-for-6.6 branch from 46f9776 to 0ab91d1 Compare May 29, 2024 08:06
@aaronrobertshaw
Copy link
Author

Thanks for the reviews and nudge to get the since/ticket comments in place. That's been done now.

I've also given this a rebase and updated the new background image test for theme.json.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! This is looking good to me now 🎉

@tellthemachines
Copy link
Contributor

Committed in r58241.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants